Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates docs about parser options #88

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Updates docs about parser options #88

merged 1 commit into from
Apr 19, 2021

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Apr 19, 2021

Fixes #10.

@hildjj
Copy link
Contributor Author

hildjj commented Apr 19, 2021 •
edited
Loading

@jaubourg I don't have a strong preference about the terminology, as long as we're consistent. "per-parse initializer" and "global initializer" work for me.

I've just started reviewing #73 in detail. I'll rework this patch as needed based on what you do there.

cleverplatypus
cleverplatypus approved these changes Apr 19, 2021
View reviewed changes
Copy link

@cleverplatypus cleverplatypus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Thanks!

@cleverplatypus
Copy link

Great job @hildjj! I mean about Peggy at large. I found PegJS a few years ago and used it in a few projects. It was sad to see such a little gem fall into the unmaintained github hole. Incremental TS support as per other comments will be amazing.
Keep it up! 🤘

@hildjj
Fixes peggyjs#10. Updates docs with an options example and making it …
c870361 
…clear that you can pass in anything you want to options.
@hildjj hildjj force-pushed the doc-parser-options branch from ef451fd to c870361 Compare April 19, 2021 23:13
@hildjj hildjj merged commit 0b7a199 into peggyjs:main Apr 19, 2021
@hildjj hildjj deleted the doc-parser-options branch April 19, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phpnode phpnode phpnode approved these changes

@cleverplatypus cleverplatypus cleverplatypus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better docs for parser options
3 participants
@hildjj @cleverplatypus @phpnode