Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all colors from ColorScheme in 3.22 #207

Closed
wants to merge 12 commits into from

Conversation

adar2378
Copy link

@adar2378 adar2378 commented Aug 6, 2024

Description

Add existing missing colors from latest ColorScheme object https://api.flutter.dev/flutter/material/ColorScheme-class.html

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Code Style Guide and followed the process outlined there for submitting PRs.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze or dart analyze) does not report any problems on my PR.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I am authorized to release this code under the MIT License and agree to do so

UI Change

Does your PR affect any UI screens?

  • Yes, the relevant screens are included below.
  • No, there are no UI impacts with this PR.

Copy link
Contributor

@jpeiffer jpeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@jpeiffer
Copy link
Contributor

jpeiffer commented Sep 4, 2024

I'd merge this, but it has conflicts. 🥲

Can you resolve those and then I can merge?

@jpeiffer
Copy link
Contributor

jpeiffer commented Sep 9, 2024

Because of conflicts, I cherry picked out the changes and applied them. Thanks for the PR.

@jpeiffer jpeiffer closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants