fix: compatibility of createElement in older versions of Chrome (vuej…

…s#9614)
peixin · Nov 16, 2023 · 1ee0f87 · 1ee0f87
1 parent 83e618f
commit 1ee0f87
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/runtime-dom/__tests__/nodeOps.spec.ts b/packages/runtime-dom/__tests__/nodeOps.spec.ts
@@ -17,6 +17,20 @@ describe('runtime-dom: node-ops', () => {
  expect(option2.selected).toBe(true)
  })
 
+ test('create custom elements', () => {
+ const spyCreateElement = vi.spyOn(document, 'createElement')
+
+ nodeOps.createElement('custom-element', false)
+ expect(spyCreateElement).toHaveBeenLastCalledWith('custom-element')
+
+ nodeOps.createElement('custom-element', false, 'li')
+ expect(spyCreateElement).toHaveBeenLastCalledWith('custom-element', {
+ is: 'li'
+ })
+
+ spyCreateElement.mockClear()
+ })
+
  describe('insertStaticContent', () => {
  test('fresh insertion', () => {
  const content = `<div>one</div><div>two</div>three`

diff --git a/packages/runtime-dom/src/nodeOps.ts b/packages/runtime-dom/src/nodeOps.ts
@@ -21,7 +21,9 @@ export const nodeOps: Omit<RendererOptions<Node, Element>, 'patchProp'> = {
  createElement: (tag, isSVG, is, props): Element => {
  const el = isSVG
  ? doc.createElementNS(svgNS, tag)
- : doc.createElement(tag, is ? { is } : undefined)
+ : is
+ ? doc.createElement(tag, { is })
+ : doc.createElement(tag)
 
  if (tag === 'select' && props && props.multiple != null) {
  ;(el as HTMLSelectElement).setAttribute('multiple', props.multiple)