You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
some places have a text field with names such as "South East" which is not relevant without the context. eg. it should read "South East Singapore".
we could fix this by adding another component to the text field so it reads "South East, Singapore" (note the comma used to concatenate components) although the rules for if/when to do that may not be consistent and may result in regressions for other names.
ideally we could fix this at source, either in the data or more likely with some mapper logic.
cc/ @nvkelso
"South East" as a feature name is legit, as long as it includes the country's name (in this case Singapore), and soft enforcement of unique at the same level (can't always do this for Locality, for instance).
It's up to the consumer of the data to construct a hierarchy based string that is less ambiguous across countries / regions. Don't think this should be changed in the quattroshapes source data.
some places have a
text
field with names such as "South East" which is not relevant without the context. eg. it should read "South East Singapore".we could fix this by adding another component to the
text
field so it reads "South East, Singapore" (note the comma used to concatenate components) although the rules for if/when to do that may not be consistent and may result in regressions for other names.ideally we could fix this at source, either in the data or more likely with some mapper logic.
cc/ @nvkelso
The text was updated successfully, but these errors were encountered: