Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

partially specified place names #28

Open
missinglink opened this issue Jul 29, 2015 · 3 comments
Open

partially specified place names #28

missinglink opened this issue Jul 29, 2015 · 3 comments

Comments

@missinglink
Copy link
Contributor

missinglink commented Jul 29, 2015

some places have a text field with names such as "South East" which is not relevant without the context. eg. it should read "South East Singapore".

we could fix this by adding another component to the text field so it reads "South East, Singapore" (note the comma used to concatenate components) although the rules for if/when to do that may not be consistent and may result in regressions for other names.

ideally we could fix this at source, either in the data or more likely with some mapper logic.
cc/ @nvkelso

{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "properties": {
        "id": "2175:adm1:sg:sgp:south_east",
        "layer": "admin1",
        "name": "South East",
        "alpha3": "SGP",
        "admin0": "Singapore",
        "admin1": "South East",
        "text": "South East"
      },
      "geometry": {
        "type": "Point",
        "coordinates": [
          103.93306123841,
          1.3481404110348
        ]
      }
    }
  ],
  "bbox": [
    103.93306123841,
    1.3481404110348,
    103.93306123841,
    1.3481404110348
  ],
  "date": 1438154960648
}
@nvkelso
Copy link

nvkelso commented Jul 29, 2015

"South East" as a feature name is legit, as long as it includes the country's name (in this case Singapore), and soft enforcement of unique at the same level (can't always do this for Locality, for instance).

It's up to the consumer of the data to construct a hierarchy based string that is less ambiguous across countries / regions. Don't think this should be changed in the quattroshapes source data.

@riordan
Copy link

riordan commented Aug 13, 2015

How is this reflected in the suggested text of the response?

@missinglink
Copy link
Contributor Author

"text": "South East" but this is due to how the outputGenerator works, see pelias/api#152 et al for more examples

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants