Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output generator tweaks #152

Closed
missinglink opened this issue Jul 6, 2015 · 3 comments · Fixed by #301
Closed

output generator tweaks #152

missinglink opened this issue Jul 6, 2015 · 3 comments · Fixed by #301
Labels

Comments

@missinglink
Copy link
Member

in the case of this document the generated .text property is 1 Main St, United Kingdom, we should aim to have 3 components at all times where at least 2 'admin' properties are available.

this is simply to give the end-user enough information about similar results so that they can disambiguate and select the correct result.

expected: 1 Main St, Dungannon, United Kingdom
actual: : 1 Main St, United Kingdom

  "features": [
    {
      "type": "Feature",
      "properties": {
        "id": "poi-address-osmnode-2656256259",
        "layer": "osmaddress",
        "name": "1 Main St",
        "alpha3": "GBR",
        "admin0": "United Kingdom",
        "admin1": "Dungannon",
        "category": [],
        "address": {
          "zip": "BT77 0BG",
          "number": "1",
          "street": "Main St"
        },
        "text": "1 Main St, United Kingdom"
      },
      "geometry": {
        "type": "Point",
        "coordinates": [
          -7.13167,
          54.428843
        ]
      }
    },
    {
@missinglink
Copy link
Member Author

related? pelias-deprecated/quattroshapes#28

@orangejulius
Copy link
Member

This will be fixed by pelias/fuzzy-tester#4 once merged :)

@missinglink
Copy link
Member Author

@orangejulius this needs to be fixed in pelias/api as it's the code to produce the human readable 'text' string

This was referenced Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants