Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1 main st gbr search test #75

Closed
wants to merge 2 commits into from

Conversation

orangejulius
Copy link
Member

No description provided.

It was set to fail, which we don't want to do anymore.
This commit reverts and modifies fec1472
@missinglink
Copy link
Member

👎 let's just delete this one?

there are a bunch of main street entries in the UK, guaranteeing priorityThresh of 3 for any of them doesn't seem like a good idea at this time.

 1) 1 Main St, United Kingdom
 2) 1 Main Street, Cockermouth CP, United Kingdom
 3) 1 Main Street, Cockermouth CP, United Kingdom
 4) 1 Main Street, Parton CP, United Kingdom
 5) 1 Main Street, Burton Joyce CP, United Kingdom
 6) 1 Main Street, Breaston CP, United Kingdom
 7) 1 Main Street, Langloan, Strathclyde
 8) 1 Main Street, Elvaston CP, United Kingdom
 9) 1 Main Street, Bretforton CP, United Kingdom
10) 1 Main Street, United Kingdom
11) 1 Main Street, Leiston CP, United Kingdom
12) 1 Main Street, Awsworth CP, United Kingdom
13) 1 Main Street, Lowdham CP, United Kingdom
14) 1 Main Street, Kirkby Lonsdale CP, United Kingdom
15) 1 Main Street, Kells, United Kingdom
16) 1 Main Street, Cramond, Lothian
17) 1 Main Street, Hilton CP, United Kingdom
18) 1 Main Street, West Ella, East Riding of Yorkshire
19) 1 Main Street, Kirkby on Bain CP, United Kingdom
20) Unit 1 Main Street, Hillfoot, Strathclyde

opened this to deal with the insufficient detail for the Dungannon result pelias/api#152

@orangejulius
Copy link
Member Author

This one definitely doesn't belong in our acceptance tests in the long term.

I wonder if someday we could have enough tests like this one that we could actually hone in on which main streets are the most popular, and therefore return the result that most people actually want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants