Remove failing tests #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
force-pushed
the
remove-failing-tests
branch
from
c2ee5bd to
266ef01
Compare
|
👍 Link this PR to open PR(s) with all the failing tests so we don't lose track of them. |
|
There was something slightly broken in production/stage(whichever env i ran against when I made this PR), that caused a few too many tests to fail, so there will be an update to this PR in a bit, stay tuned... |
orangejulius
changed the title
orangejulius
force-pushed
the
remove-failing-tests
branch
from
266ef01 to
57f638c
Compare
|
Ok, updated to reflect the correct set of failures. Also I removed each failing test in its own commit so they are easier to work with later. |
orangejulius
changed the title
|
Cool |
|
merged on the CLI :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All acceptance tests that were failing, even if the failure was expected, are removed.
Don't worry, they'll come back in individual pull requests.
12 tests total were removed, most from the feedback app that apparently used to be passing. One test was changed from failing to passing because it already was passing!