Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test, less brittle #106

Merged
merged 4 commits into from
Jul 14, 2015
Merged

fix test, less brittle #106

merged 4 commits into from
Jul 14, 2015

Conversation

missinglink
Copy link
Member

disambiguate Facebook could mean any of:

 1) Facebook
 2) Facebook, LuleÃ¥, Norrbottens län
 3) Facebook, Thapathali, Bagmati
 4) Facebook, Hyder�b�d, Andhra Pradesh
 5) Facebook Datacenter, Norrbottens län
 6) Facebook Campus, Menlo Park, CA
 7) facebook restuarant, Ahmad�b�d, Gujarat
 8) FACEBOOK Bar, Lagunes
 9) Facebook Bar, Addis Ababa
10) Facebook France, PARIS-17E-ARRONDISSEMENT, Paris
11) Facebook HQ, Menlo Park, CA
12) Facebook Boston, Cambridge, MA
13) One Facebook Way, Menlo Park, CA
14) Facebody, København, Hovedstaden
15) Facebook Data Center, Prineville, OR
16) Facebook Advertisement Nepal, Thapathali, Bagmati
17) Facebook Ireland Ltd, Dublin, Dublin City

@dianashk
Copy link
Contributor

dianashk commented Jul 8, 2015

Changing the input is cheating.

@orangejulius
Copy link
Member

This is a perfect example of a test that doesn't fit with our new definition of an acceptance test. It's not super focused, is pretty subjective, and pretty brittle. But it's also a perfect example of a great fuzzy test. Once we have a clean separation between the two, this should definitely be a fuzzy test. In fact, it should be two, one with the original input string and one with the new one, and all the expected properties should stick around in both.

orangejulius added a commit to pelias/fuzzy-tests that referenced this pull request Jul 8, 2015
From the discussion on
[acceptance-tests#106](pelias/acceptance-tests#106).
dianashk pushed a commit that referenced this pull request Jul 14, 2015
@dianashk dianashk merged commit 613d01c into master Jul 14, 2015
@orangejulius orangejulius deleted the facebook branch April 7, 2016 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants