Add test-cases for geonames categories. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_cases/categories.json -Add a bunch of test-cases for the addition of categories to GeoNames data (see [0]). -They aren't actually usable until the API can return categories, so must wait until [1] gets merged. 0: pelias/geonames#22 1: pelias/api#122
Pull in the latest of master, to take advantage of the changes to `run_tests.js` that make it correctly check object/array equality (which is necessary for the new categories test-cases).
test_cases/categories.json -The order of the elements of the `category` array in some test-cases mismatches that of the corresponding search results, even though the expected elements are there. This is a non-issue since `category` order doesn't matter, so simply change the element order to make the culprit test-cases pass.
test_cases/(feedback_pass, search).json -Merge the latest test-case updates to master, so that, when running the full test suite with the new geonames categories tests added in this branch, there aren't any unexpected failures.
test_cases/categories.json -Change the `academic` category to `education`, as per pelias/geonames@7219cce.
test_cases/categories.json -Change the order of elements in a `category` array.
sevko
added a commit
that referenced
this pull request
May 12, 2015
Add test-cases for geonames categories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test-cases for pelias/geonames#22.
fixes pelias/geonames#20