Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new test suite for french addresses #477

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Start a new test suite for french addresses #477

merged 1 commit into from
Jul 17, 2018

Conversation

adefarge
Copy link

I tried to use addresses as the end users would type them, with abbreviations, no hyphens, etc.

Some of these addresses pass on master. Others don't because the abbreviations are not recognized (r for "rue", av for "avenue", bd for "boulevard", etc.)

Some tests fail because of the hyphen in the street name ("gay lussac" vs "gay-lussac"). This is not an issue for the city names as placeholder apparently takes care of it.

Is that what you had in mind ? Feel free to tell me if I should add more test cases or modify any.

@orangejulius
Copy link
Member

This is great, I've added use of our normalizers feature which is not very well documented, to avoid any issues with capitalization.

@orangejulius orangejulius merged commit 4e23cf5 into pelias:master Jul 17, 2018
@adefarge
Copy link
Author

Great !

Yeah, about the documentation. I included NYC and London in our build to be able to run dev against it. But apparently, dev is no longer targeting only those two cities contrarily to what is said in the readme. Maybe you should update that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants