Only call language service when language not defaulted #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
force-pushed
the
skip-language-service-when-defaulted
branch
from
5d7e228
to
eea8f1d
Compare
orangejulius
force-pushed
the
skip-language-service-when-defaulted
branch
from
eea8f1d
to
98b236f
Compare
The default language is English, which is also what is stored in Elasticsearch. Thus, if the user did not specify a language via headers or query parameter, there is no reason to call Placeholder. Some Placeholder responses for language translation can be 30KB, and all that JSON takes considerable time to parse
missinglink
approved these changes
May 1, 2018
|
Upon further reflection, we may not want to merge this PR. Instead, we can disable storing, but not indexing, of the admin name fields in Elasticsearch. This should drastically cut down on the amount of data stored in Elasticsearch (all records in the USA store a duplicate copy of the string "United States", for example). For simple get requests Placeholder is quite fast, and if needed we can cache commonly used WOF records in the API (although that brings complications), so the tradeoff of an extra request to a fast service to possibly improve the efficiency of Elasticsearch by quite a bit should be worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default language is
English, which is also what is stored in Elasticsearch. Thus, if the user did not specify a language via headers or query parameter, there is no reason to call Placeholder.Some Placeholder responses for language translation can be 30KB, and all that JSON takes considerable time to parse
This was originally part of #1095
Edit: the default language is not English in WOF/Placeholder.