-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use peliasQuery analyzer for address_parts.street #1444
Merged
orangejulius
merged 1 commit into
master
from
use_peliasQuery_analyzer_for_address_parts
Jun 29, 2020
Merged
Use peliasQuery analyzer for address_parts.street #1444
orangejulius
merged 1 commit into
master
from
use_peliasQuery_analyzer_for_address_parts
Jun 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
force-pushed
the
use_peliasQuery_analyzer_for_address_parts
branch
from
June 16, 2020 18:10
758b7d2
to
d32e2a1
Compare
missinglink
force-pushed
the
use_peliasQuery_analyzer_for_address_parts
branch
from
June 23, 2020 13:39
d32e2a1
to
9d4c6db
Compare
I added another commit to enable this for autocomplete |
orangejulius
force-pushed
the
use_peliasQuery_analyzer_for_address_parts
branch
from
June 25, 2020 21:39
9d4c6db
to
870c7be
Compare
orangejulius
force-pushed
the
use_peliasQuery_analyzer_for_address_parts
branch
from
June 26, 2020 13:57
870c7be
to
54127dd
Compare
This was referenced Jun 26, 2020
missinglink
approved these changes
Jun 29, 2020
Looks good to me! |
For the record, we tested this PR in a split test and there is no noticeable performance difference compared to the master branch. I suppose a huge performance win would have been preferable, but we'll take it! |
orangejulius
force-pushed
the
use_peliasQuery_analyzer_for_address_parts
branch
from
June 29, 2020 14:46
54127dd
to
4e25f19
Compare
This is an experimental change, but one that has good impact when paired with pelias/schema#446. Essentially, this change continues the trend we have started for the `name.*` and `phrase.*` fields to generate synonyms _only_ at index time. It may be the case that variations on input vs data text (for example `crt` vs `ct` vs `court`) may cause different synonyms to be generated by the same analyzer. Many queries, especially `match_phrase` queries, will require that _all_ of those generated synonym tokens must match. This is often not desirable.
orangejulius
force-pushed
the
use_peliasQuery_analyzer_for_address_parts
branch
from
June 29, 2020 14:50
4e25f19
to
fc6e941
Compare
This was referenced Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the query-time analyzer for the
address_parts.street
field frompeliasStreet
topeliasQuery
.The latter does not generate synonyms, so it'll be much more performant and also likely produce better quality results, so win-win 🤞