Language specific label formats #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
force-pushed
the
language-specific-label-formats
branch
2 times, most recently
from
3e3d420 to
539a054
Compare
This is required for language-specific label functionality
This allows labels to be customized depending on the display language selected.
orangejulius
force-pushed
the
language-specific-label-formats
branch
from
539a054 to
b5e0a62
Compare
orangejulius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the required API changes to use our new language specific label formats from pelias/labels#52 and pelias/labels#51.
The code changes required to enable this is just one line, but for now this PR also includes a change to point the
pelias-labelspackage to a branch. We shouldn't merge this PR until pelias/labels#52 is merged and released.We also might want to add a quick test or two that the language values make it into the label generator.