feat(version): remove _type

pelias · Mar 13, 2024 · 79b1607 · 79b1607
1 parent 83b64de
commit 79b1607
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/Document.js b/Document.js
@@ -143,10 +143,6 @@ Document.prototype.toESDocument = function() {
   return {
     _index: _.get(config, 'schema.indexName', 'pelias'),
     _id: this.getGid(),
-    // In ES7, the only allowed document type will be `_doc`.
-    // However underscores are not allowed until ES6, so use `doc` for now
-    // see https://github.com/elastic/elasticsearch/pull/27816
-    _type: _.get(config, 'schema.typeName', 'doc'),
     data: doc
   };
 };

diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
   },
   "dependencies": {
     "lodash": "^4.6.1",
-    "pelias-config": "^4.5.0",
+    "pelias-config": "^6.0.0",
     "through2": "^3.0.0"
   },
   "devDependencies": {

diff --git a/test/document/toESDocument.js b/test/document/toESDocument.js
@@ -3,8 +3,7 @@ const codec = require('../../codec');
 
 var fakeGeneratedConfig = {
   schema: {
-    indexName: 'example_index',
-    typeName: 'example_type'
+    indexName: 'example_index'
   }
 };
 
@@ -50,7 +49,6 @@ module.exports.tests.toESDocument = function(test) {
 
     var expected = {
       _index: 'example_index',
-      _type: 'example_type',
       _id: 'mysource:mylayer:myid',
       data: {
         layer: 'mylayer',
@@ -102,7 +100,6 @@ module.exports.tests.toESDocument = function(test) {
 
     var expected = {
       _index: 'example_index',
-      _type: 'example_type',
       _id: 'mysource:mylayer:myid',
       data: {
         source: 'mysource',
@@ -156,7 +153,6 @@ module.exports.tests.toESDocument = function(test) {
 
     var expected = {
       _index: 'example_index',
-      _type: 'example_type',
       _id: 'mysource:mylayer:myid',
       data: {
         source: 'mysource',