Explicitly close HTTP server to avoid process.exit #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `process.exit` directly can cause output to stderr/stdout to be truncated, since it [does not wait for output to streams to be sent](https://nodejs.org/api/process.html#process_process_exit_code). This probably isn't an issue here for the PIP service, but it's worth avoiding it since explicitly closing the HTTP server created by express is easy, and will cause the process to quit "naturally", as nothing else is running. We did actually run into this issue in the [fuzzy-tester](pelias/fuzzy-tester#44) and it's a pain to track down.
orangejulius
force-pushed
the
avoid-process.exit
branch
from
5452ef7
to
f1f2cf2
Compare
trescube
approved these changes
Dec 1, 2017
missinglink
approved these changes
Dec 1, 2017
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
process.exitdirectly can cause output to stderr/stdout to be truncated, since it does not wait for output to streams to be sent.This probably isn't an issue here for the PIP service, but it's worth avoiding it since explicitly closing the HTTP server created by express is easy, and will cause the process to quit "naturally", as nothing else
is running.
We did actually run into this issue in the fuzzy-tester and it's a pain to track down.