remove full_token_address_suffix_expansion #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orangejulius this should fix the issue you mentioned recently where the following two queries are not synonymous: |
|
This PR is ready for testing and merging. Originally I coupled this with another PR but I now think it's best to merge on its own. |
orangejulius
force-pushed
the
remove_full_token_address_suffix_expansion
branch
from
3dee3e6
to
0e14823
Compare
orangejulius
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
I don't recall exactly why we did it this way either, and the history isn't much help, but I agree the way this code works doesn't look ideal.
Replacing via synonyms is not ideal, and I like how this clarifies the different purposes of our synonym files.
It's clear even just from the integration tests that this allows the replacements from other synonym files to result in more of the behavior we want.
orangejulius
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Aug 5, 2019
Could be related to some of the following changes: pelias/schema#370 pelias/schema#359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a synonyms file called
full_token_address_suffix_expansionwhich I believe we can remove in favour of using the combination of two existing synonyms files (street_suffix&directionals).I can't remember the history here but the
full_token_address_suffix_expansionsynonyms are presumably intended for use when thefull_tokenis available (ie. not for partially complete tokens)Despite this, the
full_token_address_suffix_expansionfunctionality seems to avoid 'unsafe' expansions which would only be relevant for partially complete tokens.The synonyms also follow the legacy synonyms format where tokens were 'expanded' from their contracted form to their expanded form (ie. a 'replacement'), the more recent approach we've adopted is to use the
,convention in mappings rather than the=>convention which allows for either the contracted or expanded form to match.This feels good to me but I'm a little uneasy about it simply because I don't remember why it was the way it was, I think it's just because the code is old and it's better off being removed and replaced.