Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ampersand support #369

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Improved ampersand support #369

merged 2 commits into from
Jun 14, 2019

Conversation

missinglink
Copy link
Member

@missinglink missinglink commented Jun 10, 2019

Branched from #367, need to merge that PR first.

This PR improves how we support the ampersand symbol:

  • Allow prefix ngrams to be produced, so that an input of an in autocomplete will match &
  • Add support for German language

I did some investigation and it turns out that the ampersand symbol isn't as common internationally as I suspected.
For now, we support English and German but open to supporting more languages where required.

Resolves #366

This is also the last 'old style' synonyms file which uses '=>' rather than ',' for substitutions 🎉

Copy link
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@missinglink missinglink merged commit a6d43ff into master Jun 14, 2019
@Joxit Joxit deleted the ampersand branch June 15, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ampersand
2 participants