Increase guzzle timeout when running tests (#485)

* increase guzzle timeout when running tests * catch correct exception
pelican-dev · Jul 20, 2024 · 56484a2 · 56484a2
1 parent 56b4938
commit 56484a2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -41,6 +41,8 @@ jobs:
       DB_HOST: 127.0.0.1
       DB_DATABASE: testing
       DB_USERNAME: root
+      GUZZLE_TIMEOUT: 60
+      GUZZLE_CONNECT_TIMEOUT: 60
     steps:
       - name: Code Checkout
         uses: actions/checkout@v4
@@ -113,6 +115,8 @@ jobs:
       DB_HOST: 127.0.0.1
       DB_DATABASE: testing
       DB_USERNAME: root
+      GUZZLE_TIMEOUT: 60
+      GUZZLE_CONNECT_TIMEOUT: 60
     steps:
       - name: Code Checkout
         uses: actions/checkout@v4
@@ -173,6 +177,8 @@ jobs:
       QUEUE_CONNECTION: sync
       DB_CONNECTION: sqlite
       DB_DATABASE: testing.sqlite
+      GUZZLE_TIMEOUT: 60
+      GUZZLE_CONNECT_TIMEOUT: 60
     steps:
       - name: Code Checkout
         uses: actions/checkout@v4

diff --git a/app/Services/Helpers/SoftwareVersionService.php b/app/Services/Helpers/SoftwareVersionService.php
@@ -4,7 +4,7 @@
 
 use GuzzleHttp\Client;
 use Carbon\CarbonImmutable;
-use GuzzleHttp\Exception\ClientException;
+use GuzzleHttp\Exception\GuzzleException;
 use Illuminate\Support\Arr;
 use Illuminate\Contracts\Cache\Repository as CacheRepository;
 
@@ -110,7 +110,7 @@ protected function cacheVersionData(): array
                     $wingsData = json_decode($response->getBody(), true);
                     $versionData['daemon'] = trim($wingsData['tag_name'], 'v');
                 }
-            } catch (ClientException $e) {
+            } catch (GuzzleException $e) {
             }
 
             $versionData['discord'] = 'https://pelican.dev/discord';