Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify the server Timezone at egg level #21

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

QuintenQVD0
Copy link
Contributor

Changes

  • Allow a server to set a time zone that is not the same as the one in that wings config
  • This is done with the env variable SERVER_TIMEZONE
  • If it does not exist then it will use the time zone out of the wings config
  • if it exists but is empty it will still use the wings config one
  • if it exists it does a check with the time library if it is a valid timezone, if it is it sets it to the TZ variable if not it falls back to the wings config one

This maybe not that useful for now (for some it will), but if the panel add-ons feature is there you can just make a fancy UI for it

Screenshots

ENV variable does not exist

NO_ENV

ENV exist but is empty

ENV_EMPTY

ENV with invalid timezone

ENV_NOT_VALID

ENV exist with a valid timezone

ENV_SET_CUSTOM

QuintenQVD0 and others added 2 commits June 1, 2024 19:35
Copy link
Contributor

@parkervcp parkervcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamkubi iamkubi merged commit d411477 into pelican-dev:main Jun 2, 2024
6 checks passed
@QuintenQVD0 QuintenQVD0 deleted the server_timezones branch June 3, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants