Add a parameter to disable configuration file automatic creation

[superdarki]

Changes

• This should add the possibility to disable automatic creation of the configuration files by the daemon
• Closes Support glob for configuration files panel#608 (comment) (as explained in the discussion, adding a flag instead of glob support might be better)

Why

In very specific cases, configuration files should not be created by the daemon before the server first startup as they have not been created during the installation process.
This new flag enables egg creators to specify (default true) if the file should be created or not when the daemon tries to parse it.

What it add

(This is just an example on the Vanilla Minecraft egg, this is not where I think the flag would be useful)

How

When the daemon tries to open the file to parse it, changing the function to Open instead of Touch makes it return an error instead of creating the file. If the error is "IsNotExist" and "create_file" is false just return without logging an error.

Config parser file open function edition :

Add the flag to the ConfigurationFile struct :

UnmarshalJSON function addition :

[superdarki]

I have a bug with my pelican install (docker related), I can't test if the IsNotExist error handling works.

[superdarki]

Tested it and now it works, the error handling and the not creation of the file

[theremygit]

UP

[gOOvER]

UP

??

[QuintenQVD0]

This now conflicts with this: #34

and is there anyone realy needing this?

[superdarki]

Hi, sorry haven't really been able to check github for a while.
Idk if anyone other than me really needs this but I'll still fix it when I find the time this week.
I think it's still a neat addition if someone needs it (like me) and doesn't want the hassle in creating weird egg configs when they could have used this.

[superdarki]

I finally took the time to fix the conflicts

[parkervcp]

@superdarki
If this is a change to the file parser there needs to be a change on the panel side to match that. Do you have a change submitted for that as well?

[superdarki]

Hi @parkervcp,
No I did not submit any change to the panel as it works without it but it might be a bit janky in how I did it.
I'll do that then and send the link here when published.

[parkervcp]

Hi @parkervcp, No I did not submit any change to the panel as it works without it but it might be a bit janky in how I did it. I'll do that then and send the link here when published.

You can cancel on that. I read it as an egg feature and not part of the file json. This doesn't need a panel side change.

[superdarki]

Ok, perfect then.
Thank you very much