Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Update egg-curse-forge-generic.json #2449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dhkatz
Copy link
Contributor

@dhkatz dhkatz commented Aug 31, 2023

Some reported a few issues via DMs on Discord so I wrote a quick update to fix the issues.

ServerStarter Support

I also added support for ServerStarter which is used by All of Fabric and Enigmatica mod packs. There may be more but those are the big ones I've seen so far.

Modpacks which use this format do not include any mods in their server packs or a manifest.json. Intead we download the server-starter-*.jar and use that to launch the server. It handles downloading all the mods and starting the server using a server-startup-config.yaml

Description

Fixed issue with CurseForge modpacks with escape characters in name.

Fixed issue with older versions of Minecraft in CurseForge modpacks.

Here is a gist so you can see the installation script by itself

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
  • The egg was exported from the panel

Fixed issue with CurseForge modpacks with escape characters in name.

Fixed issue with older versions of Minecraft in CurseForge modpacks.
@HerrSammyDE
Copy link
Contributor

Was successfully tested by me

@dhkatz
Copy link
Contributor Author

dhkatz commented Sep 4, 2023

May need to also look into my Modrinth egg to see if it needs to support ServerStarter too

@parkervcp parkervcp self-assigned this Oct 9, 2023
@parkervcp
Copy link
Collaborator

@dhkatz It's probably likely that the modrinth egg will require supporting ServerStarter as well. If you want to lump that in here as well.

@rowbawts
Copy link

rowbawts commented Mar 5, 2024

I'm currently testing this now and although it works it seems to use the JVM arguments for RAM specified in the server-startup-config.yaml and not the actual Ptero build configuration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants