Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V Rising (Vanilla)] 1.0 Release Update #11

Merged
merged 2 commits into from
May 14, 2024
Merged

[V Rising (Vanilla)] 1.0 Release Update #11

merged 2 commits into from
May 14, 2024

Conversation

redthirten
Copy link
Contributor

Description

  • Updated startup command to include the -gamePort parameter to accommodate the switch to Server Host Settings configuration via environment variables only.
  • Updated startup flag string to be more accurate.
  • Updated stop command to stop server gracefully.
  • Updated the install script to no longer require dos2unix or ServerHostSettings.json creation/parsing (all env. vars. now; as stated above).
  • Updated all Startup Variables:
    • All changes made were to align the variables with the officially communicated Server Host Settings.
    • Any added variables are new to 1.0.
    • Any removed variables are not listed in the above link, but may still be manually set by hand.
    • Any edited variables were done so to either facilitate the switch to env-var-based Host Settings, or align their descriptions/rules to be up to date with the link above.
  • Updated my author email.
  • Updated README with more accurate links and better descriptions.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
  • You verify that the start command applied does not use a shell script
  • The egg was exported from the panel

- Updated startup command to include the `-gamePort` parameter to accommodate the switch to Server Host Settings configuration via environment variables only.
- Updated startup flag string to be more accurate.
- Updated stop command to stop server gracefully.
- Updated the install script to no longer require `dos2unix` or `ServerHostSettings.json` creation/parsing (all env. vars. now; as stated above).
- Updated all Startup Variables:
  - All changes made were to align the variables with the officially communicated [Server Host Settings](https://github.com/StunlockStudios/vrising-dedicated-server-instructions/blob/master/1.0.x/INSTRUCTIONS.md#server-host-settings).
  - Any added variables are new to 1.0.
  - Any removed variables are not listed in the above link, but may still be manually set by hand.
  - Any edited variables were done so to either facilitate the switch to env-var-based Host Settings, or align their descriptions/rules to be up to date with the link above.
- Updated my author email.
- Updated README with more accurate links and better descriptions.
Copy link
Contributor

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, not tested yet but does match all their docs so fine for me.

Game Difficulty is actually a subset of Game Settings; not a completely different set of settings. Therefore, the startup variable's description and rules have been updated to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants