Use Mau v 2.x #14
Merged
Use Mau v 2.x #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmayer
requested changes
Oct 19, 2021
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "pelican-mau-reader" | |||
| version = "1.0.2" | |||
| version = "2.0.0" | |||
There was a problem hiding this comment.
The change to this line should be reverted. The version number will be automatically incremented by AutoPub, based on the value specified in the Release type: field. Since in this case that value is specified as major, the version number will be automatically incremented from 1.0.x to 2.0.0 when AutoPub processes the RELEASE.md file.
There was a problem hiding this comment.
You are right, I don't really know why I did it 🤦
| @@ -31,7 +31,7 @@ classifiers = [ | |||
| python = ">=3.6.2,<4.0" | |||
| pelican = ">=4.5" | |||
| markdown = {version = ">=3.2", optional = true} | |||
| mau = ">=1.4.0,<2.0" | |||
| mau = ">=2.0.0" | |||
There was a problem hiding this comment.
Congrats on removing the upper bound. More and more, I get the feeling that upper bounds on version specifiers may well be an anti-pattern. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new API of Mau 2.x and ensures that version is installed through the requirements