Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with amazon #67

Open
selfarian opened this issue Sep 8, 2014 · 28 comments
Open

Problems with amazon #67

selfarian opened this issue Sep 8, 2014 · 28 comments

Comments

@selfarian
Copy link

I installed a new copy of the opendb 1.6.0beta4.
I also installed the amazonde site plugin (even tried it with amazon).
Whe i create a new item, i can search for it and it's found. But if i choose one of the found items, the input form for the film is empty. So only the title is filled in, with the term, which i searched.
With imdb, it works. Do i need to do more setup or sth like that or is it out of order?

@pellcorp
Copy link
Owner

pellcorp commented Sep 9, 2014

Most likely the format has changed. Please provide some sample searches which fail and I will take a look

@selfarian
Copy link
Author

Ok. So for Example:
The Titles were correctly added

Searching for "Men in Black" 3 :
http://www.amazon.de/exec/obidos/ASIN/B0085J9KWC

"Hilfe Dinosaurier":
http://www.amazon.de/exec/obidos/ASIN/B00KDFLZWO

Der "Hobbit": Smaugs Einöde:
http://www.amazon.de/exec/obidos/ASIN/B00HCEP2Y6

Are these the things, you needed to know?

@pellcorp
Copy link
Owner

pellcorp commented Sep 9, 2014

Perfect I will take a look and see if I can fix the plugin

@utopiabound
Copy link
Contributor

I'm having trouble when doing a search with ISBN13 UPC (e.g. 9780553564938) I get "No Matches Found", This seems to always happen currently.

utopiabound added a commit to utopiabound/opendb that referenced this issue Sep 9, 2014
This adjusts the search to match what Amazon seems to return when searching
via ISBN13 UPC.
pellcorp added a commit that referenced this issue Sep 9, 2014
@selfarian
Copy link
Author

I'm unsure: if the problem get's fixed, you'll post it here, right?

@pellcorp
Copy link
Owner

I will. I have a 8 week old son and a 4yo son so time is a commodity I don't have a lot of. I will try to look at this this week

@selfarian
Copy link
Author

No problem, i have a 18 month old son, too. I just saw there some changes in the repository with this issue number, so i was unsure if i get a message if it's fixed :-)

@pellcorp
Copy link
Owner

The pull request submitted by Utopiabound which I merged, does not actually deal specifically with your bug. I am not sure why he referenced this bug number, probably a typo.

@pellcorp
Copy link
Owner

Ok - so they have completely revamped the amazon web site since this plugin was last written. It's no wonder it does not return any info anymore. I will work on the amazon.com and amazon.co.uk site, but I am not multilingual so I am not sure how well I will do for the non english sites.

@pellcorp
Copy link
Owner

Actually I was mistaken, it seems that we are taken to the Instant video result page by default now. The original DVD page still is there. So the search results return results for instant video as well, which is probably the titles you clicked on. I will see about excluding them from the results.

@selfarian
Copy link
Author

Hm... are you sure? The upper links seem to me to be the normal links of the DVDs... but maybe i'm wrong...

@selfarian
Copy link
Author

Do you know something new?

@pellcorp
Copy link
Owner

pellcorp commented Oct 8, 2014

No the problem is actually that the search results return links for streaming media as well which has completely different format. The layout of DVD bluray etc remains same. I don't know how to filter out the streaming results and have not had chance to get back to it

@selfarian
Copy link
Author

Hm... what format do you expect? I tried the links above and i got this (http://www.amazon.de/exec/obidos/ASIN/B00HCEP2Y6):
top_amazon
and i think, this should be the required information:
middle_amazon

@pellcorp
Copy link
Owner

I don't have much time for fixing site plugins at the moment.

@selfarian
Copy link
Author

Ok. If i can help anyway, just tell me :-) i have a little experience in php-development.

@pellcorp
Copy link
Owner

pellcorp commented Dec 4, 2014

I added code to ignore the amazon streaming video options from search. Give it a go.

@selfarian
Copy link
Author

I replaced the file amazon.class.php and i also tried to reinstall the plugin. But it doesn't work. Do i need to do anything more?

@pellcorp
Copy link
Owner

pellcorp commented Dec 4, 2014

That should be all you need. I had only tested USA site.

@pellcorp
Copy link
Owner

pellcorp commented Dec 4, 2014

Oh I only dealt with search results. Not exact matches. I will take another look

@selfarian
Copy link
Author

Ah, ok. Thank you!

@selfarian
Copy link
Author

Hi, i searched a little bit and i think i found the problem or one of it:
In line 585 of the amazon.class.php is the following:
$this->addItemAttribute('actors', parse_amazon_video_people("Actors", $pageBuffer));
So, this works only for the english site, because in germany (or amazon.de) it's not "Actors" but "Darsteller". So if i change it this way:
$this->addItemAttribute('actors', parse_amazon_video_people("Darsteller", $pageBuffer));
i have the Actors filled by the plugin.

@selfarian
Copy link
Author

I did a quick and dirty fix, so i just replaced the english-lines with german ones. If you want, i can send it to you, or create a table or so, with the english and german fieldnames.

@pellcorp
Copy link
Owner

pellcorp commented Dec 9, 2014

that would be great.

On Wed, Dec 10, 2014 at 12:17 AM, selfarian notifications@github.com
wrote:

I did a quick and dirty fix, so i just replaced the english-lines with
german ones. If you want, i can send it to you, or create a table or so,
with the english and german fieldnames.


Reply to this email directly or view it on GitHub
#67 (comment).

@selfarian
Copy link
Author

Ok, here it is:
Genres - n/a (i think it's not longer available on .com and .de)
Actors - Darsteller
Directors - Reggisseur(e)
Region - Region (it's the same, but Blu-rays have "Alle Regionen" = "all regions"
Aspect Ratio - Bildseitenformat
Number of Discs - Anzahl Disks
Rated - FSK
Studio - Studio
DVD Release Date - Erscheinungstermin
Run Time - Spieldauer
anamorphic - n/a
THX Certified - n/a
Language - Sprache (i think here's some more modification needed)
Subtitles - Untertitel
DVD Features - n/a

IMBD ID is not available maybe there's another way to get it...

Another Question i have: Is it possible to get the android app? Or is it stopped? I didn't find a link or a way to join the google group.

Thank you very much!

@pellcorp
Copy link
Owner

The android app is on a break I don't have much time to devote to it. Two
kids can do that including a 5 month old baby :-)

@selfarian
Copy link
Author

Ok. I know what you mean, mine is 21 month :-)

@selfarian
Copy link
Author

I'm unsure if i should open another bug or to post it here. It regards the amazon plugin, too.
If i try to search for an asin (barcode) i get an "unknown error" when i click on search. Here's a example of a german asin:
888430489899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants