Decode: assign empty struct to empty defined sections #879
Conversation
|
Thanks a lot for the patch, and sorry for the delay! Not sure what that check was about either, but I think having round-trip equality is a good property to have. |
pelletier
changed the title
|
Looks like removing this check either made some code unused, or created untested cases. Do you mind taking a look and removing the code or adding relevant tests so that we are sure we don't miss anything? Otherwise, I can check next weekend. |
|
Sorry for the delay, I was travelling during the week. I tried looking into this but I am afraid I am not familiar enough with the codebase to understand why the coverage went down or how to increase it back. If this is something you could help with I'd really appreciate it. Thanks! |
|
@pelletier do you think you could help with the coverage, please? |
|
Done; thank you for the nudge! |
|
Awesome! Thanks for the help :) |
pelletier
changed the title
Fixes #878
Not sure what the gate in the patched method was intended to do but it was preventing from creating pointers to structs correctly when a section was defined. This change ensures that
original_document == Marshal(Unmarsal(original_document)which isn't the case without this patch.