go.mod: bump minimum language version to 1.21 #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI only tests Go 1.21 and 1.22, and older versions of Go are no longer getting any bug or security fixes, so advertise that we only support Go 1.21 or later via go.mod. While here, ensure the module is tidy and resolve deprecation warnings, and remove now-unnecessary Go version build tags.
|
Thank you for submitting a PR! My current stance on this is #938. In other words, I'm not fundamentally against bumping the minimum go version, but only if there is a clear benefit to it. Since it would be preventing people stuck on older versions to use the library, the trade-off needs to be appealing. The readme advertises that only the last two versions of Go are supported, but a best effort to keep compatibility versions seem fine to me. Is it causing any issue or preventing you to do something on your end? |
|
Interesting - I tend to take the opposite stance, I bump go.mod as soon as my minimum supported Go version goes up. Any older Go version stops being tested in CI, so for me personally, the support is already gone. Even if the code happens to still build on a slightly older Go version, I'm not testing it, so all bets are off. It's in my opinion better to signal that via a minimum version in go.mod than to leave the users in a bit of a limbo. Nowadays there shouldn't be an excuse to stay on an older and unsupported Go version (without security updates even), particularly given https://go.dev/doc/toolchain :) In practical terms, yes, it would be very nice to be able to use newer std additions and generics. As master is right now, we only test on Go 1.21+, but we are not able to use any standard library APIs added after 1.16, which is contradictory. |
The latter is more efficient, and allocates less, since sort.Slice
needs to go through sort.Interface which causes allocations.
goos: linux
goarch: amd64
pkg: github.com/pelletier/go-toml/v2/benchmark
cpu: AMD Ryzen 7 PRO 5850U with Radeon Graphics
│ old │ new │
│ sec/op │ sec/op vs base │
Marshal/HugoFrontMatter-8 7.612µ ± 1% 6.730µ ± 1% -11.59% (p=0.002 n=6)
│ old │ new │
│ B/s │ B/s vs base │
Marshal/HugoFrontMatter-8 65.52Mi ± 1% 74.11Mi ± 1% +13.11% (p=0.002 n=6)
│ old │ new │
│ B/op │ B/op vs base │
Marshal/HugoFrontMatter-8 5.672Ki ± 0% 5.266Ki ± 0% -7.16% (p=0.002 n=6)
│ old │ new │
│ allocs/op │ allocs/op vs base │
Marshal/HugoFrontMatter-8 85.00 ± 0% 73.00 ± 0% -14.12% (p=0.002 n=6)
|
The performance improvement is worth the bump. Let's do it! |
pelletier
changed the title
dmathieu
referenced
this pull request
in open-telemetry/opentelemetry-go-contrib
Aug 26, 2024
…6040) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/pelletier/go-toml/v2](https://togithub.com/pelletier/go-toml) | `v2.2.2` -> `v2.2.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pelletier/go-toml (github.com/pelletier/go-toml/v2)</summary> ### [`v2.2.3`](https://togithub.com/pelletier/go-toml/releases/tag/v2.2.3) [Compare Source](https://togithub.com/pelletier/go-toml/compare/v2.2.2...v2.2.3) <!-- Release notes generated using configuration in .github/release.yml at v2.2.3 --> #### What's Changed ##### What's new - Allow `int`, `uint`, and `float` as map keys by [@​daniel-weisse](https://togithub.com/daniel-weisse) in [https://github.com/pelletier/go-toml/pull/958](https://togithub.com/pelletier/go-toml/pull/958) ##### Performance - Remove unstable.Parser allocation when creating Decoder by [@​mvdan](https://togithub.com/mvdan) in [https://github.com/pelletier/go-toml/pull/953](https://togithub.com/pelletier/go-toml/pull/953) ##### Fixed bugs - Fix reflect.Pointer backward compatibility by [@​xxxVitoxxx](https://togithub.com/xxxVitoxxx) in [https://github.com/pelletier/go-toml/pull/956](https://togithub.com/pelletier/go-toml/pull/956) ##### Documentation - Fix readme typo by [@​testwill](https://togithub.com/testwill) in [https://github.com/pelletier/go-toml/pull/951](https://togithub.com/pelletier/go-toml/pull/951) ##### Other changes - go.mod: bump minimum language version to 1.21 by [@​mvdan](https://togithub.com/mvdan) in [https://github.com/pelletier/go-toml/pull/949](https://togithub.com/pelletier/go-toml/pull/949) - Bump testing to go 1.23 by [@​pelletier](https://togithub.com/pelletier) in [https://github.com/pelletier/go-toml/pull/961](https://togithub.com/pelletier/go-toml/pull/961) #### New Contributors - [@​mvdan](https://togithub.com/mvdan) made their first contribution in [https://github.com/pelletier/go-toml/pull/949](https://togithub.com/pelletier/go-toml/pull/949) - [@​testwill](https://togithub.com/testwill) made their first contribution in [https://github.com/pelletier/go-toml/pull/951](https://togithub.com/pelletier/go-toml/pull/951) - [@​xxxVitoxxx](https://togithub.com/xxxVitoxxx) made their first contribution in [https://github.com/pelletier/go-toml/pull/956](https://togithub.com/pelletier/go-toml/pull/956) **Full Changelog**: pelletier/go-toml@v2.2.2...v2.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)