Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Malayalam #53

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

support Malayalam #53

wants to merge 7 commits into from

Conversation

Casxt
Copy link

@Casxt Casxt commented Dec 12, 2023

Hi @pemistahl,
I'm happy to add a new language to this amazing project.
I've carefully followed the SOP for adding a new language, and everything looks good. However, I've noticed a slight change in the whatlang output, pls kindly check this if needed.

@pemistahl
Copy link
Owner

Thanks a lot for this PR. I will need some time to review it but I will get back to you as soon as I'm done with it.

@pemistahl
Copy link
Owner

@Casxt Some unit tests have failed. Can you fix them please?

@Casxt
Copy link
Author

Casxt commented Dec 25, 2023

@Casxt Some unit tests have failed. Can you fix them please?

Hi @pemistahl, ut should be fixed

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b30f17c) 87.48% compared to head (d4286db) 87.43%.

Files Patch % Lines
alphabet.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   87.48%   87.43%   -0.05%     
==========================================
  Files           8        8              
  Lines        1598     1608      +10     
==========================================
+ Hits         1398     1406       +8     
- Misses        147      149       +2     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants