Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-108640 Added ignoredCriticalfPatterns #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

APP-108640 Added ignoredCriticalfPatterns #176

wants to merge 1 commit into from

Conversation

mibanescu
Copy link

@mibanescu mibanescu commented Sep 3, 2024 •
edited by kiefersmith
Loading

This change is Reviewable

sgp
sgp requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@sgp sgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mibanescu)

error_reporting_test.go line 173 at r1 (raw file):

}

func (e *ErrorReportingTest) TestCriticalf_Ignores(c *C) {

I think maybe your test for "Ignores" is not in the right test (by its name).

sgp
sgp approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@sgp sgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: [merge]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mibanescu)

@pendo-ops
Copy link
Contributor

pendo-ops commented Sep 3, 2024 •
edited by jira bot
Loading

JIRA status checks failed:

  • APP-108640: Invalid state 'Backlog' for merge into master

@pendo-ops
Copy link
Contributor

Failed pendo.io/jira-ref check. Please correct Jira references in the following commits:

4e26e51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgp sgp sgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mibanescu @pendo-ops @sgp