-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add design principles #14
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see if I can resolve the merge conflict here in Github so that the lookaside is built. Let me know if you have any questions about my other comments!
<hr> | ||
|
||
<h2> Dos and Don’ts</h2> | ||
<p><b>DO:</b> consider these principles when actively making your design decisions. This is the best time to leverage them.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think that <strong>
is preferred over <b>
nowadays.
@@ -14,6 +14,10 @@ const routes = [ | |||
path: '/getting-started', | |||
component: () => import('@/views/HomePage.vue') | |||
}, | |||
{ | |||
path: '/design-principles', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'll work perfectly fine for a top-level page! However, if you prefer MDX, you could always create a directory content/design-principles
with an index.mdx
file in there and just write Markdown. That strategy would remove the need to write a custom Vue component, and also eliminate the need to add the router entry manually. Just a callout!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -164,6 +58,7 @@ const NAV_ITEMS = [ | |||
{ title: 'Release Notes' }, | |||
{ title: 'About Prism' }, | |||
{ title: 'Getting Started', path: '/getting-started' }, | |||
{ title: 'Design Principles Toolkit', path: '/design-principles' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went ahead and resolved this merge conflict.
Added design principles as per confluence document created originally by Holly Reynolds and Joe Dreimann