optimization for when maskAllText is false rrweb-io#1096

pendo-io · Nov 7, 2023 · 08ac4b0 · 08ac4b0
1 parent 2e37a31
commit 08ac4b0
Showing 1 changed file with 32 additions and 13 deletions.
diff --git a/packages/rrweb-snapshot/src/snapshot.ts b/packages/rrweb-snapshot/src/snapshot.ts
@@ -363,21 +363,40 @@ export function needMaskingText(
         : node.parentElement;
     if (el === null) return false;
 
-    const unmaskDistance = distanceToMatch(
-      el,
-      createMatchPredicate(unmaskTextClass, unmaskTextSelector),
-    );
-
     let maskDistance = -1;
-    if (maskAllText && unmaskDistance < 0) {
-      return true;
-    }
+    let unmaskDistance = -1;
 
-    maskDistance = distanceToMatch(
-      el,
-      createMatchPredicate(maskTextClass, maskTextSelector),
-      unmaskDistance >= 0 ? unmaskDistance : Infinity,
-    );
+    if (maskAllText) {
+      unmaskDistance = distanceToMatch(
+        el,
+        createMatchPredicate(unmaskTextClass, unmaskTextSelector),
+      );
+
+      if (unmaskDistance < 0) {
+        return true;
+      }
+
+      maskDistance = distanceToMatch(
+        el,
+        createMatchPredicate(maskTextClass, maskTextSelector),
+        unmaskDistance >= 0 ? unmaskDistance : Infinity,
+      );
+    } else {
+      maskDistance = distanceToMatch(
+        el,
+        createMatchPredicate(maskTextClass, maskTextSelector),
+      );
+
+      if (maskDistance < 0) {
+        return false;
+      }
+
+      unmaskDistance = distanceToMatch(
+        el,
+        createMatchPredicate(unmaskTextClass, unmaskTextSelector),
+        maskDistance >= 0 ? maskDistance : Infinity,
+      );
+    }
 
     return maskDistance >= 0
       ? unmaskDistance >= 0