Revert grid template prs #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guntherjh
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dkindel)
|
Not crazy about how many tests are failing. When we upgraded pendo-main w/ upstream master after the vite upgrade, I think we missed fixing some tests that previously used jest (and now use vi). I can try to fix it in this PR, or I can create a separate PR to try to clean up tests... thoughts? |
|
I'd do it in a separate PR. Let's keep these changes specific to the revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to keep our fork clean, we are going to revert the commits which brought in the original grid template fix (which contains a bug). The hope is that this will make it easier to work with a single PR for upstream and our fork which will contain a modified version of the original fix.
Reverted the following commits:
https://github.com/rrweb-io/rrweb/pull/1396/commits
Note: reverting the changeset commit wasn't working w/
git revertso I manually deleted the file in a separate commit.