preserve adopted styles from nodes being removed when virtual dom is in use #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed pendo.io/jira-ref check. Please correct Jira references in the following commits: |
1 similar comment
|
Failed pendo.io/jira-ref check. Please correct Jira references in the following commits: |
jaj1014
reviewed
Feb 3, 2025
|
Talked f2f. My only potential concern here would be performance, but given the timing of the fix with everything else we have going on, I'm good to defer verifying that for now. Since we'll be releasing this as part of the beta player, this change is only being roled out to a very small subset of users, and we have the option to take them out of the beta segment if anything catastrophic happens. |
guntherjh
approved these changes
Feb 3, 2025
megboehlert
force-pushed
the
mb-preserve-adopted-styles
branch
from
08be4ad to
247736a
Compare
|
Failed pendo.io/jira-ref check. Please correct Jira references in the following commits: |
guntherjh
approved these changes
Feb 3, 2025
jaj1014
approved these changes
Feb 3, 2025
guntherjh
approved these changes
Feb 3, 2025
|
[merge] |
|
Branch mb-preserve-adopted-styles deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.