Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable price feeds for pen and ars on batching server #31

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Enable price feeds for pen and ars on batching server #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39dd20f
Add test for ARS and PEN fiat prices
ebma Sep 26, 2024
be86238
Add ARS and PEN to list of default supported currencies
ebma Sep 26, 2024
8a63c50
Remove useless action from CI
ebma Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,4 @@ jobs:

- name: Check Build
run: |
SKIP_WASM_BUILD=1 cargo check --release

- name: Check Build for Benchmarking
run: >
pushd node &&
cargo check --features=runtime-benchmarks --release
SKIP_WASM_BUILD=1 cargo check --release
24 changes: 23 additions & 1 deletion dia-batching-server/src/api/polygon.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,9 +396,13 @@ mod tests {
AssetSpecifier { blockchain: "FIAT".to_string(), symbol: "TZS-USD".to_string() };
let aud_asset =
AssetSpecifier { blockchain: "FIAT".to_string(), symbol: "AUD-USD".to_string() };
let ars_asset =
AssetSpecifier { blockchain: "FIAT".to_string(), symbol: "ARS-USD".to_string() };
let pen_asset =
AssetSpecifier { blockchain: "FIAT".to_string(), symbol: "PEN-USD".to_string() };
let usd_asset =
AssetSpecifier { blockchain: "FIAT".to_string(), symbol: "USD-USD".to_string() };
let assets = vec![&usd_asset, &brl_asset, &eur_asset, &ngn_asset, &tzs_asset, &aud_asset];
let assets = vec![&usd_asset, &brl_asset, &eur_asset, &ngn_asset, &tzs_asset, &aud_asset, &ars_asset, &pen_asset];

let result = polygon_api.get_prices(assets.clone()).await;
assert!(result.is_ok());
Expand Down Expand Up @@ -458,5 +462,23 @@ mod tests {
assert_eq!(aud_price.name, aud_asset.symbol);
assert_eq!(aud_price.blockchain, Some("FIAT".to_string()));
assert!(aud_price.price > 0.into());

let ars_price = prices
.iter()
.find(|q| q.symbol == ars_asset.symbol)
.expect("Should return a ARS price");
assert_eq!(ars_price.symbol, ars_asset.symbol);
assert_eq!(ars_price.name, ars_asset.symbol);
assert_eq!(ars_price.blockchain, Some("FIAT".to_string()));
assert!(ars_price.price > 0.into());

let pen_price = prices
.iter()
.find(|q| q.symbol == pen_asset.symbol)
.expect("Should return a PEN price");
assert_eq!(pen_price.symbol, pen_asset.symbol);
assert_eq!(pen_price.name, pen_asset.symbol);
assert_eq!(pen_price.blockchain, Some("FIAT".to_string()));
assert!(pen_price.price > 0.into());
}
}
2 changes: 1 addition & 1 deletion dia-batching-server/src/args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ pub struct DiaApiArgs {
#[clap(short, long,
parse(from_str = parse_currency_vec),
env = "SUPPORTED_CURRENCIES",
default_value = "FIAT:USD-USD,FIAT:EUR-USD,FIAT:BRL-USD,FIAT:AUD-USD,FIAT:NGN-USD,FIAT:TZS-USD,Pendulum:PEN,Amplitude:AMPE,Polkadot:DOT,Kusama:KSM,Astar:ASTR,Bifrost:BNC,Bifrost:vDOT,HydraDX:HDX,Moonbeam:GLMR,Polkadex:PDEX,Stellar:XLM,Picasso:PICA"
default_value = "FIAT:USD-USD,FIAT:EUR-USD,FIAT:BRL-USD,FIAT:AUD-USD,FIAT:NGN-USD,FIAT:TZS-USD,FIAT:PEN-USD,FIAT:ARS-USD,Pendulum:PEN,Amplitude:AMPE,Polkadot:DOT,Kusama:KSM,Astar:ASTR,Bifrost:BNC,Bifrost:vDOT,HydraDX:HDX,Moonbeam:GLMR,Polkadex:PDEX,Stellar:XLM,Picasso:PICA"
)]
pub supported_currencies: SupportedCurrencies,

Expand Down
Loading