update version of substrate dependencies to polkadot v0940 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for upgrading this whole repository. It is unfortunate that together with the pallet we have a whole runtime and node here, although we only need the pallet. This makes upgrading to a new Polkadot version much harder.
We should consider to change this in the future.
ebma
requested changes
May 23, 2023
There was a problem hiding this comment.
It's really great that you got the benchmarking working again but we have to be careful with the values as I think we changed few of them manually (as the benchmarks were broken at the time). Let's maybe remove the weight generation from this PR again as you suggested @b-yap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially closes pendulum issue 219
General overview of the changes:
<T as frame_system::Config>::Origin::from(RawOrigin::Root)to a shorter:RawOrigin::Root.into()in benchmarking.rspallet_grandpain runtime