242 - unsafe integer cast for BalanceConversion's StaticLookUp implementation
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-yap
force-pushed
the
242-LIP-01_unsafe_integer_cast
branch
from
a8ea7cc to
0fb72a2
Compare
if the i64 value reaches negative, make it zero for u128
b-yap
force-pushed
the
242-LIP-01_unsafe_integer_cast
branch
from
0fb72a2 to
5bdc044
Compare
ebma
reviewed
Feb 14, 2023
primitives/src/lib.rs
Outdated
| (stellar_stroops * CONVERSION_RATE as i64) as u128 | ||
| let conversion_rate = i64::try_from(CONVERSION_RATE).unwrap_or(i64::MAX); | ||
|
|
||
| let value = stellar_stroops * conversion_rate; |
There was a problem hiding this comment.
Maybe we should even use saturating_mul() here, just to be safe
RustNinja
approved these changes
Feb 14, 2023
ebma
approved these changes
Feb 14, 2023
b-yap
added a commit
that referenced
this pull request
Feb 14, 2023
…plementation (#256) * if conversion rate is too big for i64, set it to what its max is. if the i64 value reaches negative, make it zero for u128 * https://github.com/pendulum-chain/spacewalk/pull/256/files#r1105566371
b-yap
added a commit
that referenced
this pull request
Feb 15, 2023
…plementation (#256) * if conversion rate is too big for i64, set it to what its max is. if the i64 value reaches negative, make it zero for u128 * https://github.com/pendulum-chain/spacewalk/pull/256/files#r1105566371
ebma
added a commit
that referenced
this pull request
Feb 16, 2023
* 242 removing unnecessary conversion of a vector (#247) * fix weight for mint tokens in redeem pallet (#259) * first iteration (#258) * TryFrom `CurrencyId` Implementations Contain Repeated Code (#249) * 242 - secret exposed in cli (#255) * first iteration * update the readme , for the `stellar_vault_secret_key_filepath`. * add the example secret key file * applying cargo fmt * update the readme * if conversion rate is too big for i64, set it to what its max is. if the i64 value reaches negative, make it zero for u128 * Revert "if conversion rate is too big for i64, set it to what its max is." This reverts commit 399f175. * since DOT is already at 20, 20 should not fail. changed it to 30. * 242 - unsafe integer cast for `BalanceConversion`'s `StaticLookUp` implementation (#256) * if conversion rate is too big for i64, set it to what its max is. if the i64 value reaches negative, make it zero for u128 * https://github.com/pendulum-chain/spacewalk/pull/256/files#r1105566371 * fix metadata-standalone.scale * updated metadata scala * TryFrom `CurrencyId` Implementations Contain Repeated Code (#249) * Update metadata-standalone.scale --------- Co-authored-by: B. Yap <2826165+b-yap@users.noreply.github.com> Co-authored-by: cr4pt0 <102041955+cr4pt0@users.noreply.github.com>
ebma
added a commit
that referenced
this pull request
Feb 23, 2023
* 242 removing unnecessary conversion of a vector (#247) * fix weight for mint tokens in redeem pallet (#259) * first iteration (#258) * TryFrom `CurrencyId` Implementations Contain Repeated Code (#249) * 242 - secret exposed in cli (#255) * first iteration * update the readme , for the `stellar_vault_secret_key_filepath`. * add the example secret key file * applying cargo fmt * update the readme * if conversion rate is too big for i64, set it to what its max is. if the i64 value reaches negative, make it zero for u128 * Revert "if conversion rate is too big for i64, set it to what its max is." This reverts commit 399f175. * since DOT is already at 20, 20 should not fail. changed it to 30. * 242 - unsafe integer cast for `BalanceConversion`'s `StaticLookUp` implementation (#256) * if conversion rate is too big for i64, set it to what its max is. if the i64 value reaches negative, make it zero for u128 * https://github.com/pendulum-chain/spacewalk/pull/256/files#r1105566371 * fix metadata-standalone.scale * updated metadata scala * TryFrom `CurrencyId` Implementations Contain Repeated Code (#249) * Update metadata-standalone.scale --------- Co-authored-by: B. Yap <2826165+b-yap@users.noreply.github.com> Co-authored-by: cr4pt0 <102041955+cr4pt0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is item #5 of #242
if conversion rate is too big for i64, set it to what its max is.
if the i64 value reaches negative, make it zero for u128.
^ Unless that's the wrong approach?