added error logs and debug #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
reviewed
Jul 20, 2023
There was a problem hiding this comment.
Should we change the log level of the 'sent ...' and 'rcv...' logs to debug?
clients/stellar-relay-lib/src/connection/connector/message_handler.rs
Outdated
Show resolved
Hide resolved
clients/stellar-relay-lib/src/connection/connector/message_handler.rs
Outdated
Show resolved
Hide resolved
ebma
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Don't mind all these comments, I started suggesting improvements but then realized that it's easier to just add them myself immediately, less overhead for everyone. I actually tried to cancel/delete those but apparently GitHub didn't want me to haha.
Anyways, thanks for your improvements @b-yap, I just tried to make the log messages of info or higher level more human-friendly. I think it's good now
|
@b-yap I noticed I introduced some compilation errors 😅 Can you take care of those or should I? |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #356
added new logs, removed unnecessary ones, and downgrade/upgrade levels of existing logs