Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Polkadot v1.1.0 #536

Merged
merged 80 commits into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
792522b
update dependencies, fixing compilation errors (WIP)
gianfra-t May 31, 2024
d68c728
update pallets to 1.1.0
gianfra-t Jun 3, 2024
2e01bf8
fix subxt feature flags
gianfra-t Jun 3, 2024
691c276
fix client configuration new fields
gianfra-t Jun 3, 2024
ce07e26
fix clippy issues and missing std flag
gianfra-t Jun 3, 2024
aa3b152
update fixes and missing configs for runtimes
gianfra-t Jun 3, 2024
43b8e8e
fixes to node configuration (wip)
gianfra-t Jun 3, 2024
64f1e2e
node client fixes
gianfra-t Jun 4, 2024
757fc15
bump subxt to minimum viable version
gianfra-t Jun 5, 2024
791bcec
use static wrapper for account_id and currency_id metadata replacement
gianfra-t Jun 5, 2024
3c789cc
use account_id struct from subxt implementing Encode and Decode as ty…
gianfra-t Jun 5, 2024
5a08ccf
fix account type conversion using new subxt type
gianfra-t Jun 5, 2024
0b51df6
missing flag, cleanup unused types
gianfra-t Jun 5, 2024
fcd9d62
temprary remove conditional metadata
gianfra-t Jun 5, 2024
fb69df3
use foucoco metadata only
gianfra-t Jun 5, 2024
2d3bb68
warnings and type conversion
gianfra-t Jun 6, 2024
3f2869f
re-implement hashable trait
gianfra-t Jun 6, 2024
d2662c6
replace account_id on tests
gianfra-t Jun 6, 2024
4c93ad2
use subxt version 0.29 across crates
gianfra-t Jun 6, 2024
d0aab2b
modification of service config values
gianfra-t Jun 6, 2024
42922b6
testing increase in timeout for tests
gianfra-t Jun 6, 2024
b6052d5
prints for testing
gianfra-t Jun 7, 2024
e6bbcc2
bump to subxt 0.30.0
gianfra-t Jun 7, 2024
195a144
temp remove unrelated jobs
gianfra-t Jun 7, 2024
255a5a1
work with ubuntu latest
gianfra-t Jun 10, 2024
4d27e96
bump to subxt 0.33
gianfra-t Jun 10, 2024
cdb98e5
local linux tests
gianfra-t Jun 11, 2024
ac90c88
testing finalizing first block solution
gianfra-t Jun 11, 2024
9e7411a
setup working locally
gianfra-t Jun 11, 2024
15123b1
test only integration on ci
gianfra-t Jun 12, 2024
e38eef9
cleaning up temporary changes
gianfra-t Jun 12, 2024
531829e
small code improvements
gianfra-t Jun 12, 2024
caa61ea
more comment removal
gianfra-t Jun 12, 2024
9b76de9
use ubuntu latest os for main test
gianfra-t Jun 12, 2024
a5ca112
Use different function to set exchange rate
ebma Jun 13, 2024
08e18ea
`lookup_bytes` is only used here. Removing `.clone()`.
b-yap Jun 19, 2024
0b4950e
cleanup
gianfra-t Jun 21, 2024
4409eef
handle all metadata instances
gianfra-t Jun 21, 2024
204a054
temporary disable unused code on test file
gianfra-t Jun 21, 2024
17f84cf
add all-features flag to vault
gianfra-t Jun 21, 2024
078b639
addresses the confusing `all-features` feature of `runtime` package;
b-yap Jun 25, 2024
f84d351
comment cleanups
b-yap Jun 25, 2024
6b7313c
use macos image for main workflow testing
gianfra-t Jul 16, 2024
34c3fa5
revert
b-yap Jul 19, 2024
183d6d7
print current directory
b-yap Jul 19, 2024
4cf01c1
remove toolchain
b-yap Jul 19, 2024
d61fb05
ran cargo +nightly-2024-02-09 fmt --all
b-yap Jul 22, 2024
7f25b8f
revert, to use ubuntu
b-yap Jul 23, 2024
b5380b5
Revert to mac-os
gianfra-t Jul 23, 2024
dd5b86b
uncomment failing test
gianfra-t Jul 23, 2024
a90264e
force install rustup
gianfra-t Jul 23, 2024
e620216
use macos-13
b-yap Jul 24, 2024
08da9d6
ignore subxt issues, and print out proof error
b-yap Jul 24, 2024
255845c
Merge branch 'main' into polkadot-v1.1.0
b-yap Jul 24, 2024
36a1217
Revert "ignore subxt issues, and print out proof error"
b-yap Jul 24, 2024
73582d8
Revert "Merge branch 'main' into polkadot-v1.1.0"
b-yap Jul 24, 2024
8268af8
ignore failing subxt tests and print out proof error
b-yap Jul 24, 2024
b43a1eb
update cargo lock https://github.com/pendulum-chain/spacewalk/actions…
b-yap Jul 25, 2024
ac9eb47
fix cargo.lock; update only dia-oracle
b-yap Jul 26, 2024
714cf5d
update network
b-yap Jul 26, 2024
238b1db
add back iowa
b-yap Jul 26, 2024
a2f1957
[DO NOT MERGE] Test issue on Linux due to update. (#540)
gianfra-t Jul 26, 2024
7489452
stellar relay config sdftest2 ip change
gianfra-t Jul 28, 2024
62ddca5
fixing some regressions from incomplete merge
gianfra-t Jul 29, 2024
ae87c82
fixing more merge issues
gianfra-t Jul 29, 2024
d5ffec6
missing changes from #538
gianfra-t Jul 29, 2024
a518fb4
fix AccountId PrettyPrint impl
gianfra-t Jul 29, 2024
02621db
fix compare spec version name
gianfra-t Jul 29, 2024
ba8724d
fix benchmark changes merge issue
gianfra-t Jul 29, 2024
33a6067
remove when possible explicit declaration of pallets in construct_run…
gianfra-t Jul 29, 2024
2ca77fc
cargo fmt
gianfra-t Jul 29, 2024
15ef005
remove all-features feature
gianfra-t Jul 29, 2024
3345c90
testing inherent modification
gianfra-t Jul 29, 2024
17f8100
Revert "remove when possible explicit declaration of pallets in const…
gianfra-t Jul 29, 2024
7422812
Revert "Revert "remove when possible explicit declaration of pallets …
gianfra-t Jul 29, 2024
5f1058f
regenerate metadata after removal of explicit pallet delcaration in m…
gianfra-t Jul 29, 2024
daa838c
Revert "testing inherent modification"
gianfra-t Jul 30, 2024
512a09b
use pendulum's polkadot-sdk fork with modified constant
gianfra-t Jul 30, 2024
f46a753
modification of stellar sdftest3 ip
gianfra-t Jul 30, 2024
0026854
modify also vault resources sdftest3 ip
gianfra-t Jul 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions .github/workflows/ci-dev.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
on:
pull_request:
branches:
- '**' # every branch
- '!main' # excluding main
- '!main'

name: continuous-integration-dev

Expand Down Expand Up @@ -37,6 +36,8 @@ jobs:
sudo rm -rf "$AGENT_TOOLSDIRECTORY"
- uses: actions/checkout@v2



- name: Install sccache (ubuntu-latest)
if: matrix.os == 'ubuntu-latest'
env:
Expand All @@ -48,6 +49,7 @@ jobs:
curl -L "$LINK/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz
mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache
echo "$HOME/.local/bin" >> $GITHUB_PATH

- name: Install sccache (macos-latest)
if: matrix.os == 'macos-latest'
run: |
Expand Down Expand Up @@ -100,23 +102,24 @@ jobs:
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Check Build
if: matrix.rust == 'stable'
run: |
bash ./scripts/cmd-all build check
# - name: Check Build
# if: matrix.rust == 'stable'
# run: |
# bash ./scripts/cmd-all build check

- name: Test
if: matrix.rust == 'nightly'
uses: actions-rs/cargo@v1
env:
RUST_LOG: info
SOURCE_STELLAR_SECRET_MAINNET: ${{ secrets.SOURCE_STELLAR_SECRET_MAINNET }}
SOURCE_STELLAR_SECRET_TESTNET: ${{ secrets.SOURCE_STELLAR_SECRET_TESTNET }}
DEST_STELLAR_SECRET_MAINNET: ${{ secrets.DEST_STELLAR_SECRET_MAINNET }}
DEST_STELLAR_SECRET_TESTNET: ${{ secrets.DEST_STELLAR_SECRET_TESTNET }}
with:
toolchain: nightly-2024-02-09
command: test
args: --all --all-features
command: test
args: test_register_vault --all --all-features -- --nocapture

- name: Rustfmt
if: matrix.rust == 'nightly'
Expand Down
134 changes: 80 additions & 54 deletions .github/workflows/ci-main.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,25 @@
on:
pull_request:
branches:
- 'main'
- 'main' # excluding main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't mean "only main" instead of "excluding main"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course, in any case this comment is from copying the dev and only temporary.


name: continuous-integration-main
jobs:
ci:
strategy:
max-parallel: 2
matrix:
rust: [ stable, nightly ]
runs-on: ubuntu-20.04
os: [ ubuntu-24.04, macos-latest ]
rust: [ nightly ]
include:
- os: ubuntu-24.04
sccache-path: /home/runner/.cache/sccache
- os: macos-latest
sccache-path: /Users/runner/Library/Caches/Mozilla.sccache


runs-on: ${{ matrix.os }}

env:
RUST_BACKTRACE: full
# Make sure CI fails on all warnings, including Clippy lints
Expand All @@ -19,37 +28,42 @@ jobs:
steps:
- name: Freeing up more disk space
run: |
free -h
sudo rm -rf /usr/local/lib/android # will release about 10 GB if you don't need Android
sudo rm -rf /usr/share/dotnet # will release about 20GB if you don't need .NET
sudo rm -rf /opt/ghc
sudo rm -rf /usr/local/share/boost
sudo rm -rf /opt/hostedtoolcache/CodeQL
sudo rm -rf "$AGENT_TOOLSDIRECTORY"
sudo apt-get remove -y 'php.*' --fix-missing
sudo apt-get remove -y '^mongodb-.*' --fix-missing
sudo apt-get remove -y '^mysql-.*' --fix-missing
sudo apt-get clean
df -h
- uses: actions/checkout@v2

- name: Install package
- name: Install sccache (ubuntu-24.04)
if: matrix.os == 'ubuntu-24.04'
env:
LINK: https://github.com/mozilla/sccache/releases/download
SCCACHE_VERSION: 0.2.13
run: |
SCCACHE_FILE=sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl
mkdir -p $HOME/.local/bin
curl -L "$LINK/$SCCACHE_VERSION/$SCCACHE_FILE.tar.gz" | tar xz
mv -f $SCCACHE_FILE/sccache $HOME/.local/bin/sccache
echo "$HOME/.local/bin" >> $GITHUB_PATH
sudo apt-get install pkg-config libssl-dev

- name: Install sccache (macos-latest)
if: matrix.os == 'macos-latest'
run: |
sudo docker image prune --all --force
echo 'APT::Get::Always-Include-Phased-Updates "false";' | sudo tee /etc/apt/apt.conf.d/99-phased-updates
sudo apt-get update && sudo apt-get upgrade -y
sudo apt-get install -y protobuf-compiler libprotobuf-dev
brew update
brew install sccache

- name: Setup stable Rust toolchain
if: matrix.rust == 'stable'
# Call `rustup show` as a hack so that the toolchain defined in rust-toolchain.toml is installed
run: rustup show
# - name: Setup Rust toolchain
# if: matrix.rust == 'stable'
# # Call `rustup show` as a hack so that the toolchain defined in rust-toolchain.toml is installed
# run: rustup show

- name: Remove rust-toolchain.toml for nightly
if: matrix.rust == 'nightly'
# To make sure that the nightly version will be used all throughout
run: |
rm /home/runner/work/spacewalk/spacewalk/rust-toolchain.toml
# - name: Remove rust-toolchain.toml for nightly
# if: matrix.rust == 'nightly'
# # To make sure that the nightly version will be used all throughout
# run: |
# rm /home/runner/work/spacewalk/spacewalk/rust-toolchain.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that this is not needed anymore? Or did you remove it because the path in l. 45 was not found?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was required. was commented out just to test but has been re-added.


- name: Setup nightly Rust toolchain
if: matrix.rust == 'nightly'
Expand All @@ -67,49 +81,61 @@ jobs:
uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
key: "ubuntu-latest-cargo-${{ hashFiles('**/Cargo.lock') }}"
key: "${{ matrix.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}"
shared-key: "shared"

- name: Save sccache
uses: pat-s/always-upload-cache@v3
continue-on-error: true
with:
path: "${{ matrix.sccache-path }}"
key: "${{ matrix.os }}-sccache-${{ hashFiles('**/Cargo.lock') }}"
restore-keys: "${{ matrix.os }}-sccache-"

- name: Start sccache server
run: sccache --start-server

- name: Install Protoc
uses: arduino/setup-protoc@v1
uses: arduino/setup-protoc@v3
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Check Build
if: matrix.rust == 'stable'
run: |
bash ./scripts/cmd-all build check
# - name: Check Build
# if: matrix.rust == 'stable'
# run: |
# bash ./scripts/cmd-all build check

- name: Test
if: matrix.rust == 'nightly'
uses: actions-rs/cargo@v1
env:
SOURCE_STELLAR_SECRET_MAINNET: ${{ secrets.SOURCE_STELLAR_SECRET_MAINNET }}
SOURCE_STELLAR_SECRET_TESTNET: ${{ secrets.SOURCE_STELLAR_SECRET_TESTNET }}
DEST_STELLAR_SECRET_MAINNET: ${{ secrets.DEST_STELLAR_SECRET_MAINNET }}
DEST_STELLAR_SECRET_TESTNET: ${{ secrets.DEST_STELLAR_SECRET_TESTNET }}
RUST_LOG: info
# SOURCE_STELLAR_SECRET_MAINNET: ${{ secrets.SOURCE_STELLAR_SECRET_MAINNET }}
# SOURCE_STELLAR_SECRET_TESTNET: ${{ secrets.SOURCE_STELLAR_SECRET_TESTNET }}
# DEST_STELLAR_SECRET_MAINNET: ${{ secrets.DEST_STELLAR_SECRET_MAINNET }}
# DEST_STELLAR_SECRET_TESTNET: ${{ secrets.DEST_STELLAR_SECRET_TESTNET }}
with:
toolchain: nightly-2024-02-09
command: test
args: --all --all-features
command: test
args: test_register_vault --all --all-features -- --nocapture

- name: Rustfmt
if: matrix.rust == 'nightly'
uses: actions-rs/cargo@v1
with:
toolchain: nightly-2024-02-09
command: fmt
args: --all -- --check
# - name: Rustfmt
# if: matrix.rust == 'nightly'
# uses: actions-rs/cargo@v1
# with:
# toolchain: nightly-2024-02-09
# command: fmt
# args: --all -- --check

- name: Clippy -- Libraries and Binaries
if: matrix.rust == 'stable'
run: |
bash ./scripts/cmd-all clippy "clippy --lib --bins" "-- -W clippy::all -A clippy::style -A forgetting_copy_types -A forgetting_references"
# - name: Clippy -- Libraries and Binaries
# if: matrix.rust == 'stable'
# run: |
# bash ./scripts/cmd-all clippy "clippy --lib --bins" "-- -W clippy::all -A clippy::style -A forgetting_copy_types -A forgetting_references"

- name: Clippy -- Tests and Examples
if: matrix.rust == 'nightly'
uses: actions-rs/cargo@v1
with:
toolchain: nightly-2024-02-09
command: clippy
args: --all-features --tests --benches --examples -- -A clippy::all -W clippy::correctness -A forgetting_copy_types -A forgetting_references
# - name: Clippy -- Tests and Examples
# if: matrix.rust == 'nightly'
# uses: actions-rs/cargo@v1
# with:
# toolchain: nightly-2024-02-09
# command: clippy
# args: --all-features --tests --benches --examples -- -A clippy::all -W clippy::correctness -A forgetting_copy_types -A forgetting_references
Loading
Loading