[READY] Migrate signer-service to Typescript #352
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Thanks for going through this tedious process @Sharqiewicz 👌 Looks good overall, I just found a few things we might want to improve.
Some remarks:
- IIRC our deployment currently assumes that
yarn startis enough to run the signer-service. If we now split it up intoyarn buildandyarn start, we'll have to touch the deployment instructions of the service or it won't start. This is an important consideration before we merge this. Either we a) combine building and running inyarn startor b) change the deployment steps. b) is favorable IMO. - The linting seems to be broken.
yarn lintfinds lots of issues that doesn't seem like issues to me. Maybe we need to change the config files.
signer-service/src/api/controllers/googleSpreadSheet.controller.ts
Outdated
Show resolved
Hide resolved
…om:pendulum-chain/vortex into 281-switch-to-typescript-in-signer-service
Sharqiewicz
changed the base branch from
polygon-prototype-staging
to
staging
|
@ebma so |
| } | ||
| }; | ||
|
|
||
| export const sendStatusWithPkController = async (_req: Request, res: Response, _next: NextFunction) => { |
There was a problem hiding this comment.
I think we're not using this fn anymore.
There was a problem hiding this comment.
Good catch @gianfra-t
| export const SUPPORTED_FIAT_CURRENCIES = ['eur', 'ars'] as const; | ||
| export type FiatCurrency = (typeof SUPPORTED_FIAT_CURRENCIES)[number]; | ||
|
|
||
| export interface QuoteRequest { |
There was a problem hiding this comment.
Nit: This type is unused and a duplicate of QuoteQuery
There was a problem hiding this comment.
Maybe it's just me, but don't you think the comments we had were helpful @pendulum-chain/devs? I suggest we re-add them because the logic is not obvious.
|
@ebma ✅ |
PR 🦈🟢
signer-serviceto Typescriptyarn buildCompiles TypeScript code into JavaScript using the fast SWC compileryarn startRuns the compiled applicationyarn build:startCompiles and then immediately runs the application (When you want to test production)yarn devRuns the application in development mode with automatic reloading on code changesHow to review
There are only two new files
.swcrcandtsconfig.jsonthey are short and consistent.The challenge with the review is going through every migrated file. I tried to keep the logic the same, but sometimes there were a lot of TypeScript errors, so I had to make changes to the files.