implement offramp summary popup

[Sharqiewicz]

No description provided.

[netlify]

✅ Deploy Preview for pendulum-pay ready!

Name	Link
🔨 Latest commit	7810dd6
🔍 Latest deploy log	https://app.netlify.com/sites/pendulum-pay/deploys/679a455cc148d1000836abbc
😎 Deploy Preview	https://deploy-preview-394--pendulum-pay.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ebma]

Really nice job @Sharqiewicz, it looks amazing 🙏

It's not defined in the ticket but I would suggest we don't close the offramp dialog when the user clicks on 'Continue to partner'. This has some advantages:

• The user doesn't see that the exchange rates/quotes still continuously change/refresh in the base form.
• The user can switch back and forth between the anchor page and vortex to double check the expected values

I would continue showing the info dialog all the way until we switch over to the progress page. WDYT @pendulum-chain/devs and also @pendulum-chain/product?

[prayagd]

I would continue showing the info dialog all the way until we switch over to the progress page. WDYT

i agree to this suggestion

[prayagd]

couple of comments

• Change You're offramping to You're selling, now that we are call everything sell
• There is lot of delay if i close the pop-up change the input amount and again click on confirm until the pop-up reappears
• For the Partner thing please follow the alignment move the link to the right below similar to how other details are aligned to right and also please remove the "-" from partner
• Both partner links are wrong please make mykobo - https://www.mykobo.co/ anclap - https://home.anclap.com/
• I know not mentioned in the acceptance criteria is it possible to make the links? clicking them should open the website in new page

[Sharqiewicz]

@prayagd @ebma @gianfra-t The comments are addressed ✅

[ebma]

Looks and feels fantastic, great job @Sharqiewicz 🙏

One bug I noticed: When I have the summary dialog open and click on the 'x' to close it, the 'Confirm' button keeps spinning. As a user, I would expect that the I can interact with the form again, change amounts, and click on 'Confirm' again to open the dialog with a fresh quote. Currently I have to refresh the page.

[gianfra-t]

Looks cool 😎.

Besides the thing @ebma mentioned, I noticed that when I rejected the approve transaction and later clicked "Try Again" it brought me to the swap page, but the summary popup was still there. I think it should behave similar to closing it when there is a failure.

Also, do you think we could bring the signing box to the front focus too? Not greyed out, I mean. I guess this is more opinionated.

[Sharqiewicz]

@gianfra-t I think the popup should only appear after the ARS approve tx is signed so it doesn't interfere with the SigningBox

[gianfra-t]

Even better solution! Thanks.

[ebma]

Let's follow up with the bug I reported on Slack after merging this.

@Sharqiewicz can you please create a ticket for the remaining issue (continue to partner button pending after closing and reopening the offramp summary)?