feat(socialaccounts): Check in User.email for account matching email address #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…address Currently when EMAIL_AUTHENTIFICATION is True, we only checks for other socialaccount accounts and not for accounts in User. The usecase is when migrating the authentification system to one using User.email to store emails to allauth which use EmailAddress.emails This probably should be behind a configuration flag, I'm not an Django expert so maybe there is better way to do this.
pennersr
requested changes
Oct 13, 2023
| @@ -338,6 +338,14 @@ def _lookup_by_email(self): | |||
| self.connect(context.request, address.user) | |||
| else: | |||
| self.user = address.user | |||
| return | |||
|
|
|||
| user = get_user_model().objects.filter(email__in=emails).first() | |||
There was a problem hiding this comment.
Not all user models have an email field. Also, email casing needs to be taken into account, so this should likely be replaced by filter_users_by_email(). I think that the existing EmailAddress.objects.lookup(emails).order_by("-verified", "user_id").first() line could be replaced by it, so no need to duplicate the if that follows here.
|
Closed via 26158b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting Pull Requests
General
Examples:
"fix(google): Fixed foobar bug","feat(accounts): Added foobar feature".ChangeLog.rst.AUTHORS.Currently when EMAIL_AUTHENTIFICATION is True, we only checks for other socialaccount accounts and not for accounts in User. The usecase is when migrating the authentification system to one using User.email to store emails to allauth which use EmailAddress.emails
This probably should be behind a configuration flag, I'm not an Django expert so maybe there is better way to do this.