Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-cd): add terraform #146

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(argo-cd): add terraform #146

wants to merge 3 commits into from

Conversation

jonathankao97
Copy link
Contributor

No description provided.

@jonathankao97
Copy link
Contributor Author

jonathankao97 commented Apr 4, 2022

View admin UI using (admin, default password from second command):

kubectl port-forward svc/argo-cd-argocd-server -n argocd 8080:443
kubectl -n argocd get secret argocd-initial-admin-secret -o jsonpath="{.data.password}" | base64 -d; echo

Functionality:

  • Syncs all manifests available in the pennlabs/kube-manifests repository
  • If a namespace is not defined in the k8s manifest, falls back to namespace defined in server.additionalApplications.destination.namespace

Current bug:

Duplicate manifests:

@jonathankao97 jonathankao97 requested a review from ArmaanT April 4, 2022 04:13
@ArmaanT
Copy link
Member

ArmaanT commented Apr 5, 2022

Just to make sure I'm understanding it correctly, for the duplicated manifests, if I have two identical YAML copies of a certificate, argo will output a warning but still sync them, and if I delete one instance, it won't delete the certificate?

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #146 (e9a815f) into master (efd8251) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          31       31           
  Lines         433      433           
  Branches       86       86           
=======================================
  Hits          426      426           
  Misses          5        5           
  Partials        2        2           
Flag Coverage Δ
kittyhawk 97.34% <ø> (ø)
kraken 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f6cb9...e9a815f. Read the comment docs.

@ArmaanT
Copy link
Member

ArmaanT commented Apr 17, 2022

A couple more questions:

  1. Is kube-manifests repo supposed to be private? If so, we'll have to update the terraform and give argo credentials to access it.
  2. Are we planning on setting up a webhook so that argo doesn't have to keep polling the kube-manifests repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants