Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend/llm responses #293

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Backend/llm responses #293

wants to merge 5 commits into from

Conversation

benjmnxu
Copy link
Contributor

pr request

@gitguardian
Copy link

gitguardian bot commented Oct 29, 2023

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic Password 1c0595a backend/docker-compose.yaml View secret
8425562 Triggered OpenAI API Key 02d7303 backend/.env View secret
8425562 Triggered OpenAI API Key cd15d87 backend/.env View secret
8425562 Triggered OpenAI API Key 02d7303 backend/officehoursqueue/settings/base.py View secret
8425562 Triggered OpenAI API Key cd15d87 backend/officehoursqueue/settings/base.py View secret
9451515 Triggered Generic Password 40c2dea backend/docker-compose.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@trangiabach
Copy link
Contributor

pr request

Encourage writing some tests to make sure that LLM responses and settings works correctly with each CRUD operations

Pipfile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should remove this global Pipfile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should reset this yarn.lock file since we are not touching any files in the frontend

"""
return super().create(request, *args, **kwargs)

def update(self, request, *args, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should implement this update method and it should not replace but only append to the current LLM prompt

@benjmnxu benjmnxu closed this Dec 2, 2023
@benjmnxu
Copy link
Contributor Author

benjmnxu commented Dec 2, 2023

New Update to pr

@benjmnxu benjmnxu reopened this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants