-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend/llm responses #293
base: master
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic Password | 1c0595a | backend/docker-compose.yaml | View secret | |
8425562 | Triggered | OpenAI API Key | 02d7303 | backend/.env | View secret |
8425562 | Triggered | OpenAI API Key | cd15d87 | backend/.env | View secret |
8425562 | Triggered | OpenAI API Key | 02d7303 | backend/officehoursqueue/settings/base.py | View secret |
8425562 | Triggered | OpenAI API Key | cd15d87 | backend/officehoursqueue/settings/base.py | View secret |
9451515 | Triggered | Generic Password | 40c2dea | backend/docker-compose.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Encourage writing some tests to make sure that LLM responses and settings works correctly with each CRUD operations |
Pipfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should remove this global Pipfile
frontend/yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should reset this yarn.lock file since we are not touching any files in the frontend
backend/ohq/views.py
Outdated
""" | ||
return super().create(request, *args, **kwargs) | ||
|
||
def update(self, request, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should implement this update method and it should not replace but only append to the current LLM prompt
New Update to pr |
pr request