Add a dock clear button #648
Open
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esinx
requested changes
Apr 9, 2024
| @@ -140,6 +152,11 @@ const Dock = ({ user, login, logout, activeDegreeplanId }: DockProps) => { | |||
| // } | |||
| // }, [isMount, dockedCourses]); | |||
|
|
|||
| const { remove } = useSWRCrud<DockedCourse>(`/api/degree/docked`, { idKey: 'full_code' }); | |||
| const handleRemoveCourse = (full_code: string) => { | |||
There was a problem hiding this comment.
yeah we've been using full_code. That might not be a good pattern (mb if so), but tbh I think this OK for now.
There was a problem hiding this comment.
Will defer to @esinx here, but if we want to clean this up, we should probably do so at the entire project level and likely after we solve the user facing issues
10 tasks
JHawk0224
commented
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to reject lol