fix minor issue with dining insights and update some dependencies.

pennlabs · Nov 4, 2023 · e327c31 · e327c31
1 parent c7301da
commit e327c31
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/PennMobile/build.gradle b/PennMobile/build.gradle
@@ -61,7 +61,7 @@ dependencies {
     implementation 'org.apache.commons:commons-lang3:3.10'
     implementation 'androidx.annotation:annotation:1.1.0'
     implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0'
-    implementation 'androidx.coordinatorlayout:coordinatorlayout:1.1.0'
+    implementation 'androidx.coordinatorlayout:coordinatorlayout:1.2.0'
     implementation ("androidx.lifecycle:lifecycle-extensions:2.2.0@aar") {
         transitive = true
     }
@@ -70,25 +70,24 @@ dependencies {
     implementation 'com.squareup.okhttp:okhttp:2.7.5'
     implementation 'io.reactivex:rxandroid:1.2.1'
     implementation 'androidx.browser:browser:1.2.0'
-    implementation 'androidx.recyclerview:recyclerview:1.2.1'
+    implementation 'androidx.recyclerview:recyclerview:1.3.2'
     implementation 'androidx.legacy:legacy-support-v4:1.0.0'
     implementation 'com.daimajia.swipelayout:library:1.2.0'
-    implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
+    implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
     testImplementation 'junit:junit:4.13'
     androidTestImplementation 'org.testng:testng:7.1.0'
     implementation 'com.github.PhilJay:MPAndroidChart:v3.1.0'
     implementation 'androidx.cardview:cardview:1.0.0'
     implementation 'com.github.ahorn:android-rss:master-SNAPSHOT'
     // official release is several years old and is not thread-safe
-    implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.7"
+    implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.1"
     implementation 'com.eightbitlab:supportrenderscriptblur:1.0.2'
     implementation 'androidx.palette:palette-ktx:1.0.0'
     implementation 'com.github.searchy2:CustomAlertViewDialogue:2.6.1'
     implementation 'com.airbnb.android:lottie:4.2.0'
     implementation 'com.github.bumptech.glide:glide:4.11.0' // Glide for gif loading
     annotationProcessor 'com.github.bumptech.glide:compiler:4.11.0'
     implementation 'com.squareup.okhttp3:logging-interceptor:4.6.0'
-    testImplementation 'junit:junit:4.12'
     androidTestImplementation 'androidx.test.ext:junit:1.1.1'
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
     androidTestImplementation 'com.kaspersky.android-components:kaspresso:1.1.0'

diff --git a/PennMobile/src/main/java/com/pennapps/labs/pennmobile/adapters/DiningInsightsCardAdapter.kt b/PennMobile/src/main/java/com/pennapps/labs/pennmobile/adapters/DiningInsightsCardAdapter.kt
@@ -172,7 +172,12 @@ class DiningInsightsCardAdapter(private var cells: ArrayList<DiningInsightCell>)
         val yAxis: YAxis = predictionChart.axisLeft
         yAxis.typeface = tf
         yAxis.removeAllLimitLines()
-        yAxis.axisMaximum = amounts.max() ?: 0f
+        if (amounts.isEmpty()) {
+            yAxis.axisMaximum = 0f
+        } else {
+            yAxis.axisMaximum = amounts.max()
+        }
+
         yAxis.axisMinimum = 0f
         yAxis.setDrawZeroLine(false)
         yAxis.setDrawLimitLinesBehindData(false)