Refactor the core of the app using SwiftUI #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the feature icons be white on light mode? |
Aesthetic edits on anli/09-17-refactor
|
Btw, aesthetics of poll history page is inconsistent with aesthetics of a poll on the homepage
|
|
We should also remove the debug button |
fixed on mass-deletion branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long-awaited refactor of our app in SwiftUI is here.
Note that this PR updates the minimum deployment target to iOS 16.0.
Some tasks that I've deferred until later PRs:
Fixing a rare crash when switching to the GSR/laundry tabs after re-pinning them to the tab bar (those are also related to navigation bar controls)now fixed!AppFeaturestructs