Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate WebView #518

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

anli5005
Copy link
Member

Quick PR to get main building again

@anli5005
Copy link
Member Author

anli5005 commented Mar 22, 2024

For reference the duplicate view in question is:

struct WebView: UIViewRepresentable {
let url: URL
func makeUIView(context: Context) -> WKWebView {
return WKWebView()
}
func updateUIView(_ uiView: WKWebView, context: Context) {
uiView.load(URLRequest(url: url))
}
}

Copy link
Member

@JHawk0224 JHawk0224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anli5005 anli5005 merged commit f18670a into main Mar 22, 2024
1 check passed
@anli5005 anli5005 deleted the anli/03-22-remove-duplicate-web-view branch March 22, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants