Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash from unwrapping optional in GSRController #520

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

anli5005
Copy link
Member

We were getting a few crashes due to this.

Crash log from unwrapping sorted.first!

@anli5005 anli5005 requested a review from JHawk0224 March 24, 2024 16:16
@anli5005 anli5005 enabled auto-merge March 24, 2024 16:16
Copy link
Member

@JHawk0224 JHawk0224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@anli5005
Copy link
Member Author

A lot of crashes, actually
454 devices over the last year

@anli5005 anli5005 merged commit 74df06c into main Mar 24, 2024
1 check passed
@anli5005 anli5005 deleted the anli/03-24-fix-gsr-bar-button-crash branch March 24, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants