Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading of notification tokens #566

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

anli5005
Copy link
Member

@anli5005 anli5005 commented Nov 8, 2024

Previously, notification tokens weren't being uploaded due to a few issues. This PR fixes them (though itself is insufficient for a robust notification implementation):

  • Moves registerForRemoteNotifications call into the AppDelegate
  • Removes dev from the DTO for getting a device's notification ID
  • Rewrites savePushNotificationDeviceToken to send a PUT request and append a forward slash to the URL

In the future, we will need additional PRs to support multiple tokens per user, but this is a start.

@JHawk0224 JHawk0224 merged commit 04f79e8 into main Nov 9, 2024
1 check passed
@JHawk0224 JHawk0224 deleted the notifications/fix-token-upload branch November 9, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants