Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GSR Group Admin easy to add/remove users #307

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

vcai122
Copy link
Contributor

@vcai122 vcai122 commented Sep 27, 2024

For easy adding/removing users to groups

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.41%. Comparing base (4f18580) to head (ed8bf40).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
backend/gsr_booking/admin.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   90.47%   90.41%   -0.06%     
==========================================
  Files          62       62              
  Lines        2666     2681      +15     
==========================================
+ Hits         2412     2424      +12     
- Misses        254      257       +3     
Flag Coverage Δ
90.41% <75.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dr-Jess dr-Jess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vcai122 vcai122 merged commit ef44d80 into master Sep 30, 2024
7 of 9 checks passed
@vcai122 vcai122 deleted the gsr-group-admin-better branch September 30, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants