Merge pull request #1338 from dcleao/BACKLOG-26058-8.2.0.0

[BACKLOG-26058] Fix `EntityWithNumberKeyStrategy` not being marked as…
pentaho · Oct 30, 2018 · 93bb0a6 · 93bb0a6
2 parents 659792f + 662d485
commit 93bb0a6
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/...ent/src/main/javascript/web/pentaho/visual/role/adaptation/EntityWithNumberKeyStrategy.js b/...ent/src/main/javascript/web/pentaho/visual/role/adaptation/EntityWithNumberKeyStrategy.js
@@ -181,6 +181,11 @@ define([
 
       id: module.id,
 
+      /** @inheritDoc */
+      get isIdentity() {
+        return true;
+      },
+
       /** @inheritDoc */
       getInputTypeFor: function(outputDataType, isVisualKeyEf) {
 

diff --git a/impl/client/src/main/javascript/web/pentaho/visual/role/adaptation/Strategy.js b/impl/client/src/main/javascript/web/pentaho/visual/role/adaptation/Strategy.js
@@ -252,6 +252,19 @@ define([
       /**
        * Gets a value that indicates if the strategy is an identity strategy.
        *
+       * An _identity_ strategy is one for which each of its input fields
+       * corresponds to exactly one output field and vice-versa,
+       * under the same order.
+       * Moreover,
+       * the value of each input field is either the same as or equivalent to
+       * that of its output field.
+       *
+       * Under this definition,
+       * the following stock strategies are considered _identity_ strategies:
+       * * [IdentityStrategy]{@link pentaho.visual.role.adaptation.IdentityStrategy}
+       * * [TupleStrategy]{@link pentaho.visual.role.adaptation.TupleStrategy}
+       * * [EntityWithNumberKeyStrategy]{@link pentaho.visual.role.adaptation.EntityWithNumberKeyStrategy}
+       *
        * @type {boolean}
        * @readOnly
        * @overridable